Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/mcc lcc #52

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Issue/mcc lcc #52

wants to merge 21 commits into from

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

  • add mcc and hcc to the model
  • had to preprocess hcc and mcc using script
  • retrain and add models to v3

Fixes #

How Has This Been Tested?

CI tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@cfc2c97). Click here to learn what that means.
The diff coverage is 86.66%.

❗ Current head 63c1199 differs from pull request most recent head 1c1710f. Consider uploading reports for the commit 1c1710f to get more accurate results

@@           Coverage Diff           @@
##             main      #52   +/-   ##
=======================================
  Coverage        ?   43.67%           
=======================================
  Files           ?       21           
  Lines           ?      964           
  Branches        ?        0           
=======================================
  Hits            ?      421           
  Misses          ?      543           
  Partials        ?        0           
Impacted Files Coverage Δ
gradboost_pv/preprocessing/region_filtered.py 75.00% <86.66%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peterdudfield peterdudfield mentioned this pull request Mar 29, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant