Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/466 swap gsp name #467

Open
wants to merge 7 commits into
base: development
Choose a base branch
from
Open

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Feb 6, 2024

Pull Request

Description

Swap DNO name order

before

Screenshot 2024-05-14 at 13 05 35

now
Screenshot 2024-05-14 at 13 05 01

Fixes #466

How Has This Been Tested?

Looked at the new vercel branch + added some unit tests

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nowcasting-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:08am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
quartz-app ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 0:08am

@peterdudfield peterdudfield changed the base branch from main to development February 6, 2024 14:14
@rachel-labri-tipton
Copy link
Contributor

hi @peterdudfield, I'm just having a look at this and wondering what the difference is between SSE and Southern (SSE). I probably just don't know the DNO's well enough.

@peterdudfield
Copy link
Contributor Author

hi @peterdudfield, I'm just having a look at this and wondering what the difference is between SSE and Southern (SSE). I probably just don't know the DNO's well enough.

Yea, I'm not sure either

#466

I've put all the names from the api in this issue

Copy link
Contributor

@braddf braddf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterdudfield Is this new name format function intentionally trimming to Region names to only the first word? E.g. WPD (South West) becomes South (WPD) which is not quite the same information

@peterdudfield
Copy link
Contributor Author

@peterdudfield Is this new name format function intentionally trimming to Region names to only the first word? E.g. WPD (South West) becomes South (WPD) which is not quite the same information

ah good spot, not I think it lost a word there somewhere.
Let me fix that

@peterdudfield peterdudfield marked this pull request as draft May 14, 2024 11:33
@peterdudfield peterdudfield marked this pull request as ready for review May 14, 2024 12:09
@peterdudfield peterdudfield changed the base branch from development to main May 14, 2024 12:09
@peterdudfield peterdudfield changed the base branch from main to development May 14, 2024 12:09
@peterdudfield peterdudfield removed the request for review from rachel-labri-tipton May 14, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap name order on Sites aggregation regions
3 participants