Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap name order on Sites aggregation regions #466

Open
peterdudfield opened this issue Feb 6, 2024 · 4 comments · May be fixed by #467
Open

Swap name order on Sites aggregation regions #466

peterdudfield opened this issue Feb 6, 2024 · 4 comments · May be fixed by #467
Assignees

Comments

@peterdudfield
Copy link
Contributor

Dan via Vercel Preview:

For the names of the Regions, could we swap the around so they are East (UKPN), South West (WPD) etc? The reason is the region names are the primary identifier, and are fixed, but the owners of the franchises could change over time.

@peterdudfield
Copy link
Contributor Author

peterdudfield commented Feb 6, 2024

This could be done in the pv-site-datamodel and all current sites need to be updated. But this is how the data comes in from

https://api.nationalgrideso.com/dataset/0e377f16-95e9-4c15-a1fc-49e06a39cfa0/resource/e96db306-aaa8-45be-aecd-65b34d38923a/download/dno_license_areas_20200506.geojson for example
"LongName": "UKPN (East)" but some are just one "LongName": "SSE"

Options

  1. In database store dno_provider, dno_region, then load this in the FE
  2. Manipulate this data in the FE.

I think we should do option 1. @rachel-labri-tipton @braddf ?

@peterdudfield
Copy link
Contributor Author

Now looking at this, i think its ok to do in the front end, then it keeps the datatbase data and api more ture to what the DNOs are

@peterdudfield peterdudfield linked a pull request Feb 6, 2024 that will close this issue
6 tasks
@peterdudfield
Copy link
Contributor Author

@peterdudfield peterdudfield self-assigned this Feb 6, 2024
@peterdudfield
Copy link
Contributor Author

Just for reference here are all the dnos
{ "ID": 10, "Name": "_A", "LongName": "UKPN (East)"
{ "ID": 11, "Name": "_B", "LongName": "WPD (East Midlands)" }
{ "ID": 12, "Name": "_C", "LongName": "UKPN (London)" }
{ "ID": 13, "Name": "_D", "LongName": "SPEN (SP MANWEB)" }
{ "ID": 14, "Name": "_E", "LongName": "WPD (Midlands)" }
{ "ID": 15, "Name": "_F", "LongName": "NPG (Northern Electric)" }
{ "ID": 16, "Name": "_G", "LongName": "ENWL" }
{ "ID": 17, "Name": "_P", "LongName": "SSE" }
{ "ID": 18, "Name": "_N", "LongName": "SPEN (SP Distribution)" }
{ "ID": 19, "Name": "_J", "LongName": "UKPN (South)" }
{ "ID": 20, "Name": "_H", "LongName": "SSE (Southern)" }
{ "ID": 21, "Name": "_K", "LongName": "WPD (South Wales)" }
{ "ID": 22, "Name": "_L", "LongName": "WPD (South West)" }
{ "ID": 23, "Name": "_M", "LongName": "NPG (Yorkshire Electric)" }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant