add implementation of giving it live pv data

[peterdudfield]

Pull Request

Description

• Add live pv data to v1 model
• added an example
  TODO - run this with evaluation, perhaps with 1 hour of live pv data

Fixes #36

How Has This Been Tested?

Added an example and TODO run evaluation

• Yes

Checklist:

• My code follows OCF's coding style guidelines
• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have checked my code and corrected any misspellings

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (760bfd6) 0.00% compared to head (a20a240) 79.87%.

Files	Patch %	Lines
quartz_solar_forecast/data.py	57.14%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##           main      #47       +/-   ##
=========================================
+ Coverage      0   79.87%   +79.87%     
=========================================
  Files         0       11       +11     
  Lines         0      333      +333     
=========================================
+ Hits          0      266      +266     
- Misses        0       67       +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[aryanbhosale]

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

[aryanbhosale]

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

Can this be merged?

[peterdudfield]

Yea, I let this sit there for a bit. I think what needs to happen is

• resovle conficts
• run (and update) evaluation code to see how much better the model is with this live PV data.

Do you fancy doing that @aryanbhosale

[peterdudfield]

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

Its realted to #66, but this mean users can enter their live PV data into the model. And yea, this could be done using the enphase API, or other methods.

Wanted to also run the evaluation to show how much better the model is by using this data

[aryanbhosale]

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

Its realted to #66, but this mean users can enter their live PV data into the model. And yea, this could be done using the enphase API, or other methods.

Wanted to also run the evaluation to show how much better the model is by using this data

Oh that's great, are there any changes needed here ?

[peterdudfield]

Hi @peterdudfield ,what does this pr do? Is this similar to #106 that was built on #66

Its realted to #66, but this mean users can enter their live PV data into the model. And yea, this could be done using the enphase API, or other methods.
Wanted to also run the evaluation to show how much better the model is by using this data

Oh that's great, are there any changes needed here ?

Totally up to you. You could build off this branch, or start a fresh, totally up to you.