Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visualization graphs to eval #102

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JasonFengGit
Copy link

Pull Request

Description

Add visualization graphs to eval. Fix the TODO in evaluation.py
Including "Predicted VS Actual" graph for every 48hrs segments and "Error Distribution" for all tested instances.

How Has This Been Tested?

  • Yes
    Tested with python scripts/run_evaluation.py

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

Remaining Issues

  1. My code in local env uses the pip package quartz_solar_forecast, and it seems my visualization code has to be updated in the package before I can use. Investigating how to solve this.
  2. How to update documentation for this?
  3. I realize a lot of timestamps in results_df does not have real generation_power values

Examples

error_distribution.png
image

pred_vs_actual_9531_2021_07_28_22_00_00.png
image

pred_vs_actual_9531_2021_09_16_07_00_00.png
image

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.94%. Comparing base (05ae555) to head (3d9de9e).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #102   +/-   ##
=======================================
  Coverage   79.94%   79.94%           
=======================================
  Files          12       12           
  Lines         354      354           
=======================================
  Hits          283      283           
  Misses         71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JasonFengGit
Copy link
Author

Hi @jacobbieker @peterdudfield, could you give any suggestions for the issues above? Thanks!

@JasonFengGit
Copy link
Author

Hi @jacobbieker, is it a known issue that a lot of timestamps in results_df does not have real generation_power values? Thanks!

@peterdudfield
Copy link
Contributor

  1. My code in local env uses the pip package quartz_solar_forecast, and it seems my visualization code has to be updated in the package before I can use. Investigating how to solve this.

You can use pip install -e . and hopefully you can then use it

  1. How to update documentation for this?

Is there something you can add on the readme about visualization of the evaluation

  1. I realize a lot of timestamps in results_df does not have real generation_power values

Hmm this is interesting, would you be able to write which values they are. It might be worth putting these in a different issue

@JasonFengGit
Copy link
Author

  1. My code in local env uses the pip package quartz_solar_forecast, and it seems my visualization code has to be updated in the package before I can use. Investigating how to solve this.

You can use pip install -e . and hopefully you can then use it

  1. How to update documentation for this?

Is there something you can add on the readme about visualization of the evaluation

  1. I realize a lot of timestamps in results_df does not have real generation_power values

Hmm this is interesting, would you be able to write which values they are. It might be worth putting these in a different issue

Thanks! Let me address these issues. : )

@JasonFengGit JasonFengGit reopened this Apr 18, 2024
@JasonFengGit
Copy link
Author

Created an issue here #110

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants