Skip to content

Commit

Permalink
adding php version currently under active support tot the test matrix (
Browse files Browse the repository at this point in the history
…#465)

* adding php version currently under active support

Adding missing closing tag

* bumping docker compose to , fixing php 7.4 decprecation warnings
  • Loading branch information
attachmentgenie committed Feb 13, 2020
1 parent 74abe85 commit 9c55fa4
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
7 changes: 4 additions & 3 deletions .travis.yml
Expand Up @@ -3,7 +3,7 @@ services:
- docker

env:
COMPOSE_VERSION: 1.7.1
COMPOSE_VERSION: 1.25.3

before_install:
- sudo apt-get update -qq
Expand All @@ -15,6 +15,8 @@ before_install:
language: php
php:
- 7.2
- 7.3
- 7.4

script:
- composer install
Expand All @@ -29,8 +31,7 @@ deploy:
provider: releases
api_key:
secure: TRb8uQSt22NNKczLj6QvnBAjd953tb3bpQIdiltcVl7JhZ6YBWnylwEAMt3EryxD1ZqWsCS89F00VR/lo9N+iSZJfuN8xQGh76CS6MTG46DqFcgIbjkAjK3EFxqZamLfQKeQytfmIvsWJ3dDcwSjSrvvcAoI/Lklzpq2NoVfHj/6M+HX7q41tiucRfajrxC47bFgsOkljOfWuUYGteQ/hZOGeyZ5lNUfZDzSTPyaVamf6nPmHGi9Tbjks+YL6rvZ32MAkZpY4FQAFKhXELTjM6FSYW9V7n8Vq4ufaaN93UYXb3x5Yx1+ZBmAdbp3kQCt0gwe4aQtuT0kRft7rkD0Tg7Xp2ao2KyN1gzZN2ptHsXdNB9Y4yRv7pIsNPYXSQyi1ofPMWRO+zIjl1Je0kQ981YfWqu7RcqwPIQ6PVE34kT4hDMuRmzOqgrtnO07ZgozdhUCAK33aBIcGq4ZW7RXgvaNk0BmvZAP5oeM4wj/OUKpC7yw14fTOdGxETvP4E0zYc9TnfAxVhNHRGhGqWtLZshZ1/8apcjDO1eAN6x1Wa/tESWOzqADra+7ga09SSR8Agc1sVW9gW0UVqawNE83+cwzL5fO/lgIkIRVlZtsPMAYkzHMu9IeA0f1aV8yKML3znZuh8c6BKw4nZx6K/GhCqCqfNefNReaeeMMXXg99HI=

file:
file:
- $TRAVIS_BUILD_DIR/opencats-$TRAVIS_TAG-full.tar.gz
- $TRAVIS_BUILD_DIR/opencats-$TRAVIS_TAG-full.zip
skip_cleanup: true
Expand Down
1 change: 1 addition & 0 deletions ci/package-code.sh
Expand Up @@ -7,3 +7,4 @@ if [ "${TRAVIS_TAG}" != "false" ]; then if [ "${TRAVIS_TAG}" != "" ]; then
cp /tmp/opencats-$TRAVIS_TAG-full.tar.gz $TRAVIS_BUILD_DIR
cp /tmp/opencats-$TRAVIS_TAG-full.zip $TRAVIS_BUILD_DIR
fi
fi
2 changes: 1 addition & 1 deletion lib/DateUtility.php
Expand Up @@ -735,7 +735,7 @@ private static function _removeLeadingZeros($array)
foreach ($array as $key => $value)
{
/* Remove leading '0's from fields. */
if ($array[$key]{0} == '0')
if ($array[$key][0] == '0')
{
$array[$key] = substr($array[$key], 1);
}
Expand Down
4 changes: 2 additions & 2 deletions lib/StringUtility.php
Expand Up @@ -499,7 +499,7 @@ public static function makeInitialName($firstName, $lastName,

if ($lastCommaFirst)
{
$firstInitial = $firstName{0} . '.';
$firstInitial = $firstName[0] . '.';

if (strlen($lastName) > $maxLength)
{
Expand All @@ -511,7 +511,7 @@ public static function makeInitialName($firstName, $lastName,
return ucwords($lastName . ', ' . $firstInitial);
}

$lastInitial = $lastName{0} . '.';
$lastInitial = $lastName[0] . '.';

if (strlen($firstName) > $maxLength)
{
Expand Down

6 comments on commit 9c55fa4

@shantadam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@attachmentgenie Travis build is failing to authorize. Can you investigate?

@shantadam
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@attachmentgenie some of my assumptions:

  • space character changes applied around the API secure key in travis yml file.
  • Travis <> Github authorization.

@RussH
Copy link
Member

@RussH RussH commented on 9c55fa4 Mar 19, 2020 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RussH
Copy link
Member

@RussH RussH commented on 9c55fa4 Mar 19, 2020 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@attachmentgenie
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why i got pinged here, but i agree with @RussH someone with admin access will need to generate a new token

@RussH
Copy link
Member

@RussH RussH commented on 9c55fa4 Mar 19, 2020 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.