Skip to content

Commit

Permalink
Address vulnerabilities (#440)
Browse files Browse the repository at this point in the history
* Update no-response.yml

* Address XML vulnerability in DocumentToText.php

disable entity loading.

* Update DocumentToText.php
  • Loading branch information
RussH committed Jul 1, 2019
1 parent 96e1db3 commit 920a575
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/no-response.yml
@@ -1,7 +1,7 @@
# Configuration for probot-no-response - https://github.com/probot/no-response

# Number of days of inactivity before an Issue is closed for lack of response
daysUntilClose: 14
daysUntilClose: 16
# Label requiring a response
responseRequiredLabel: more-information-required
# Comment to post when closing an Issue for lack of response. Set to `false` to disable
Expand Down
1 change: 1 addition & 0 deletions lib/DocumentToText.php
Expand Up @@ -412,6 +412,7 @@ private function readZippedXML($archiveFile, $dataFile)
$zip->close();
// Load XML from a string
// Skip errors and warnings
libxml_disable_entity_loader(true);
$xml = new DOMDocument();
$xml->loadXML($data, LIBXML_NOENT | LIBXML_XINCLUDE | LIBXML_NOERROR | LIBXML_NOWARNING);
$raw_text = $xml->saveXML();
Expand Down

0 comments on commit 920a575

Please sign in to comment.