Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use insecure HTTP if enabled as build option #222

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use insecure HTTP if enabled as build option #222

wants to merge 1 commit into from

Conversation

opatut
Copy link
Member

@opatut opatut commented Feb 10, 2021

For debugging, it is easier to just flip a flag :)

@opatut opatut requested a review from amandel February 10, 2021 18:06
@sonarcloud
Copy link

sonarcloud bot commented Feb 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@amandel
Copy link
Member

amandel commented Feb 18, 2021

Looks good for local testing.
Please make additionally sure that the configured portal url does not start with https might be in Uploader::uploadFile, setting mLastStatusMessage to avoid a insecure connection is created while the user expects a secure one.

@opatut opatut marked this pull request as draft July 5, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandel amandel Awaiting requested review from amandel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@opatut @amandel