do not addrepo system repos #1069
Conversation
app/views/download/package.erb
Outdated
| @@ -69,10 +69,13 @@ pacman -Sy <%= repo_name %>/<%= @package %></pre> | |||
| <pre><%= | |||
| case v[:flavor] | |||
| when 'openSUSE', 'SLE' | |||
| if @project != "openSUSE:Factory" and @project != "openSUSE:Tumbleweed" and not @project .start_with? "openSUSE:Leap:" | |||
There was a problem hiding this comment.
I'm not sure if this list contains all projects we need to filter for Leap 15.3 since it added additional official repos
There was a problem hiding this comment.
Good point Alex, that would be openSUSE:Leap:15.3, openSUSE:Backports:SLE-15-SP3, SUSE:SLE-15:GA, SUSE:SLE-15:Update, SUSE:SLE-15-SP1:GA, SUSE:SLE-15-SP1:Update ... SUSE:SLE-15-SP3:Update for 15.3
So something like openSUSE:Leap:, openSUSE:Backports: SUSE:SLE-15* ....
I wonder if we could perhaps somehow utilized the "15.3" that we voted for and we have in OBS repositories (not projects) ...
Perhaps something like getAllProjectsByInheritance(openSUSE:Leap:15.3) and return list would be useful.
There was a problem hiding this comment.
15.3 does make this a bit more difficult to catch, considering unlike previously, there is no standard prefix to really glob here. That being said, globbing using existing project names should work just fine
|
I'm curious why not all of SLE, but SLE 15 specifically, though that's mostly a question to @lkocman, since it was his suggestion |
SLE doesn't rebuild packages each release, for example the last time dbus-1 was branched was in an update to SLE-15-SP1 so currently SLE-15-SP2 / SP3 / SP4 will all get the dbus-1 package from that repo. This means that if I do a security update and fix it in SUSE:SLE-15SP1:Update (or whatever it is) that fix will automatically be pulled into all currently supported products including Leap 15.3, SLE, SLE LTSS and any other products SUSE is building. Possibly another question here is does software.o.o know that the latest official version of dbus-1 actually comes from SUSE:SLE-15SP1:Update, if it doesn't know that then it wont find it and its not an issue. |
|
Keep in mind, all this PR does is remove a |
|
This will just remove it from the official repos? If it's also the community and experimental ones then i don't agree. |
This is not even that part of code. This relates to the download pages. It will remove reference to files that don't actually exist, official .repo files. |
Manual download: do not tell the operator to addrepo system repos (Factory, Tumbleweed or Leap)!
Fixes bsc#1185917.