Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rails: 2.15.0 → 2.18.0 (minor) #3132

Closed
wants to merge 1 commit into from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Mar 4, 2023

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.15.0 → 2.18.0) · Repo · Changelog

Release Notes

2.18.0

New features

Bug fixes

  • #824: Fix a false negative for Rails/ActionControllerTestCase when the class is namespaced. (@vlad-pisanov)
  • #909: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash before redirect_to in if branch. (@koic)
  • #898: Fix a false positive for Rails/ActiveRecordAliases when arguments of update_attributes is empty. (@koic)
  • #920: Fix an error for Rails/NegateInclude when there is no receiver. (@fatkodima)
  • #931: Fix error in Rails/Presence when ternary operators are used in multiple lines. (@r7kamura)
  • #687: Fix Rails/HasManyOrHasOneDependent to correctly handle association methods with receiver. (@fatkodima)
  • #929: Prevent Rails/SquishedSQLHeredocs applying when single-line comments are present. (@john-h-k)
  • #887: Fix a false positive for Rails/NotNullColumn when adding a :virtual column. (@fatkodima)
  • #918: Fix Rails/FreezeTime running against Rails < 5.2 apps. (@DRBragg)
  • #895: Fix Rails/UnusedIgnoredColumns not recognizing columns added via +=. (@lucthev)

Changes

  • #263: Accept actions defined via alias in Rails/LexicallyScopedActionFilter. (@fatkodima)
  • #902: Ignore redirect method for Style/FormatStringToken by default. (@javierjulio)
  • #935: Make Style/InverseMethods aware of Active Support's present?, blank?, include?, and exclude? methods. (@koic)
  • #914: Make Style/InverseMethods aware of valid? and invalid? methods. (@koic)
  • #826: Mark Rails/Pluck as unsafe. (@fatkodima)
  • #896: Raise severity of Rails/ActiveRecordOverride, Rails/DeprecatedActiveModelErrorsMethods, Rails/DuplicateAssociation, Rails/DuplicateScope, Rails/TopLevelHashWithIndifferentAccess, and Rails/WhereNotWithMultipleConditions cops to warning. (@koic)

2.17.4

Bug fixes

  • #870: Fix an error for Rails/RootPathnameMethods when using Rails.env argument within Dir.glob. (@koic)
  • #881: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline rescue branch before redirect_to. (@gurix)
  • #871: Fix a false positive for Rails/WhereMissing when left_joins(:foo) and where(foos: {id: nil}) separated by or, and. (@ydah)
  • #875: Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals. (@koic)
  • #882: Fix false positive for Rails/UniqueValidationWithoutIndex with :conditions option. (@etiennebarrie)
  • #821: Enhance Rails/TimeZone to accept methods with the :in timezone option. (@fatkodima)

Changes

2.17.3

% cat relnotes/v2.17.3.md

Bug fixes

  • #843: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using flash in multiline if branch before redirect_to. (@koic)
  • #841: Fix an error for Rails/ActionOrder when using unconventional order of multiple actions. (@koic)
  • #838: Fix an incorrect autocorrect for Rails/ActionOrder when using unconventional order of actions in conditions. (@koic)
  • #867: Fix autocorrection bug when ::Hash is used on Rails/IndexBy and Rails/IndexWith. (@r7kamura)
  • #848: Fix a false positive for Rails/FreezeTime when using travel_to with an argument of Time.new(...).in_time_zone. (@koic)
  • #869: Fix false-positives that non Rails formats are offended on Rails/ToSWithArgument. (@r7kamura)
  • #866: Fix false-positives when constant is used with receiver on Rails/DurationArithmetic, Rails/IndexBy, Rails/IndexWIth, and Rails/RequireDependency. (@r7kamura)
  • #850: Fix default configuration for Rails/I18nLazyLookup. (@vlad-pisanov)
  • #837: Fix incorrect autocorrection of Rails/ActionOrder about comments. (@r7kamura)
  • #855: Fix Rails/RootPathnameMethods autocorrection for Pathname calls without parens. (@gsamokovarov)
  • #868: Support :: prefixed constants on Rails/ActionControllerFlashBeforeRender, Rails/ActionControllerTestCase, Rails/ApplicationController, Rails/ApplicationJob, Rails/ApplicationMailer, Rails/ApplicationRecord, Rails/DotSeparatedKeys, Rails/DynamicFindBy, Rails/FindEach, Rails/FreezeTime, Rails/HasManyOrHasOneDependent, Rails/HelperInstanceVariable, Rails/MailerName, Rails/MigrationClassName, Rails/Output, Rails/ReversibleMigrationMethodDefinition, Rails/ReversibleMigration, Rails/ShortI18n, Rails/SkipsModelValidations, and Rails/TimeZoneAssignment. (@r7kamura)
  • #865: Support ::Rails and ::File on Rails/FilePath cop. (@r7kamura)

Changes

  • #862: Ignore if number of arguments does not match on Rails/DynamicFindBy. (@r7kamura)

2.17.2

Bug fixes

  • #825: Fix a false positive for Rails/ActionControllerFlashBeforeRender when using condition before redirect_to. (@koic)
  • #833: Fix a false positive for Rails/Pluck when receiver is not block argument for []. (@koic)
  • #834: Fix an error for Rails/WhereNotWithMultipleConditions when using where.not with empty hash literal. (@koic)
  • #833: Fix a false positive for Rails/Pluck when using multiple block arguments. (@koic)

Changes

  • #832: Mark Rails/ActionControllerFlashBeforeRender, Rails/ActionControllerTestCase, and Rails/RootPathnameMethods cops as unsafe autocorrection. (@koic)

2.17.1

Bug fixes

  • #829: Revert "Extends Rails/HttpStatus cop to check routes.rb" introduced in 2.17.0. (@jdufresne)
  • #831: Fix a false positive for Rails/Pluck when using block argument in []. (@koic)

2.17.0

New features

Bug fixes

  • #786: Fix a false negative for Rails/ActionControllerTestCase when extending ActionController::TestCase and having a method definition. (@koic)
  • #792: Fix a false negative for Rails/RedundantPresenceValidationOnBelongsTo when belongs_to at least one block and one hash like belongs_to :company, -> { where(foo: true) }, inverse_of: :employee. (@PedroAugustoRamalhoDuarte)
  • #781: Make Rails/DynamicFindBy aware of find_by_token_for. (@koic)
  • #809: Fix an error for Rails/FreezeTime when using travel_to without argument. (@koic)
  • #794: Fix an error for Rails/RedundantReceiverInWithOptions when calling a method with a receiver in with_options without block arguments. (@koic)
  • #782: Fix an incorrect autocorrect for Rails/EagerEvaluationLogMessage when using Style/MethodCallWithArgsParentheses's autocorrection together. (@koic)
  • #776: Fix an incorrect autocorrect for Rails/Presence when using arithmetic operation in else branch. (@koic)
  • #813: Fix errors that occur when unrelated tag is investigated by Rails/ContentTag. (@r7kamura)
  • #808: Fix false positive for Rails/ActionControllerFlashBeforeRender when render call precedes flash call. (@americodls)
  • #778: Fix a false positive for Rails/DynamicFindBy when using page.find_by_id as a Capybara testing API. (@koic)
  • #816: Fix an incorrect autocorrect for Rails/Presence when a right-hand side of the relational operator. (@ydah)

Changes

  • #779: Add mail to AllowedMethods of Style/SymbolProc. (@koic)
  • #796: Add several directories to Exclude to prevent slow investigation. (@koic)
  • #822: Extends Rails/HttpStatus cop to check routes.rb. (@anthony-robin)
  • #787: Make Rails/Pluck aware of all keys. (@koic)
  • #800: Make Rails/TimeZone aware of timezone UTF offset. (@inkstak)

2.16.1

Bug fixes

  • #769: Fix a false positive for Rails/FreezeTime when using travel_to with an argument of DateTime.new with arguments. (@koic)
  • #772: Fix a false positive for Rails/TopLevelHashWithIndifferentAccess when using HashWithIndifferentAccess under namespace module. (@koic)
  • #762: Fix an error for Rails/FreezeTime when using travel_to with an argument of current method without receiver. (@koic)
  • #764: Fix an incorrect autocorrect for Rails/FreezeTime when using travel_to with an argument of the current time and proc argument. (@koic)
  • #763: Mark Rails/RootPathnameMethods as unsafe and fix an incorrect autocorrect when using Dir.glob. (@koic)

2.16.0

New features

Bug fixes

  • #757: Fix a false positive for Rails/ReflectionClassName when using Ruby 3.1's hash shorthand syntax. (@koic)
  • #741: Fix a bad autocorrection for errors.details[:name] << value in Rails/DeprecatedActiveModelErrorsMethods. (@BrianHawley)
  • #742: Rails/DeprecatedActiveModelErrorsMethods was missing the deprecated values, to_h, and to_xml methods. (@BrianHawley)
  • #740: Fix a NoMethodError on nil for errors.keys in a model in Rails/DeprecatedActiveModelErrorsMethods. (@BrianHawley)
  • #753: Fix Rails/CompactBlank bug when offense is found in block. (@r7kamura)
  • #756: Fix incorrect documentation URLs when using rubocop --show-docs-url. (@r7kamura)
  • #754: Make Rails/RedundantReceiverInWithOptions and Rails/ReversibleMigration cops aware of numbered block parameter. (@koic)

Changes

  • #750: Deprecate IgnoredMethods option in integrate to AllowedMethods and AllowedPatterns option. (@koic)
  • #729: Change the minimum required rubocop dependency version to 1.31.0. (@pirj)

2.15.2

Bug fixes

  • #712: Fix false negative in Rails/Delegate when preceding nested class declares private or protected methods. (@Darhazer)
  • #737: Fix a false positive for Rails/DeprecatedActiveModelErrorsMethods when using keys method with Rails 6.0. (@koic)
  • #737: Make Rails/ExpandedDateRange aware beginning_of_week with an argument. (@koic)
  • #731: Fix an incorrect autocorrect for Rails/StripHeredoc. (@kazarin)

2.15.1

Bug fixes

  • #723: Fix include value in Rails/AttributeDefaultBlockValue. (@kkitadate)
  • #717: Fix an error for Rails/DeprecatedActiveModelErrorsMethods when root receiver is a variable. (@koic)
  • #719: Fix a false negative for Rails/FormattedS when using safe navigation operator. (@koic)
  • #725: Fix an incorrect autocorrect for Rails/DotSeparatedKeys when a key starts with dot. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

✳️ rubocop (1.30.1 → 1.48.1) · Repo · Changelog

Release Notes

Too many releases to show here. View the full release notes.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ concurrent-ruby (indirect, 1.1.10 → 1.2.2) · Repo · Changelog

Release Notes

1.2.2

concurrent-ruby 1.2.2:

  • (#993) Fix arguments passed to Concurrent::Map's default_proc.

1.2.1

concurrent-ruby 1.2.1:

  • (#990) Add missing require 'fiber' for FiberLocalVar.
  • (#989) Optimize Concurrent::Map#[] on CRuby by letting the backing Hash handle the default_proc.

1.2.0

concurrent-ruby 1.2.0:

  • (#975) Set the Ruby compatibility version at 2.3
  • (#962) Fix ReentrantReadWriteLock to use the same granularity for locals as for Mutex it uses.
  • (#983) Add FiberLocalVar
  • (#934) concurrent-ruby now supports requiring individual classes (public classes listed in the docs), e.g., require 'concurrent/map'
  • (#976) Let Promises.any_fulfilled_future take an Event
  • Improve documentation of various classes
  • (#972) Remove Rubinius-related code

concurrent-ruby-edge 0.7.0:

  • (#975) Set the Ruby compatibility version at 2.3
  • (#934) concurrent-ruby now supports requiring individual classes (public classes listed in the docs), e.g., require 'concurrent/map'
  • (#972) Remove Rubinius-related code

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ minitest (indirect, 5.17.0 → 5.18.0) · Repo · Changelog

Release Notes

5.18.0 (from changelog)

  • 2 major enhancements:

    • Added assert_pattern & refute_pattern for pattern matching. (flavorjones)

    • Added matching must_pattern_match & wont_pattern_match to minitest/spec.

  • 1 bug fix:

    • Support the new message format of NameError in Ruby 3.3 (mame)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.1.2.0 → 3.2.1.1) · Repo · Changelog

Release Notes

3.2.1.1 (from changelog)

API modifications:

  • bump racc to 1.6.2 (#916) (Ilya Bylich)
  • backport tests for mixed usage of anonymous kwarg/kwrestarg and forwarded-arguments (#915) (Ilya Bylich)
  • add tests for kwopt+kwrest arguments and forwarded_kwrestarg. (#913) (Ilya Bylich)

Bugs fixed:

  • builders/default: allow forwarded_kwrestarg with additional kwargs (#912) (Owen Stephens)

3.2.1.0 (from changelog)

API modifications:

  • Bump maintenance branches to 3.2.1 (#908) (Koichi ITO)
  • lexer.rl: extract strings lexing to lexer-strings.rl (#905) (Ilya Bylich)

Features implemented:

  • Ruby 3.3 support (#904) (Ole Friis Østergaard)

3.2.0.0 (from changelog)

API modifications:

  • lexer.rl: extract extend_string_escaped to a separate method (#893) (Ilya Bylich)
  • bump Racc to 1.6.1 (#890) (Koichi ITO)

Features implemented:

  • lexer.rl: use Ragel -F0 on non-CRuby (#894) (Benoit Daloze)
  • ruby32.y: Allow optional newlines before closing parenthesis (#892) (Koichi ITO)

Bugs fixed:

  • ruby32.y: fix a parse error when using forwarded argument with restarg (#889) (Koichi ITO)

3.1.3.0 (from changelog)

API modifications:

  • Bump maintenance branches to 3.1.3, 3.0.5, 2.7.7 (#886) (Koichi ITO)
  • ruby32.y: reuse nonlocal_var rule. (#879) (Ilya Bylich)
  • ruby32.y: reuse opt_nl rule. (#878) (Ilya Bylich)

Features implemented:

  • ruby32.y: implement forwarded restarg and kwrestarg. (#874) (Ilya Bylich)

3.1.2.1 (from changelog)

Bugs fixed:

  • ruby31.y: fix preparing the state for one-line patterns without braces (#864) (Vladimir Dementyev)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ regexp_parser (indirect, 2.5.0 → 2.7.0) · Repo · Changelog

Release Notes

2.7.0 (from changelog)

Added

  • Regexp::Lexer.lex now streams tokens when called with a block
    • it can now take arbitrarily large input, just like Regexp::Scanner
    • this also slightly improves Regexp::Parser.parse performance
    • note: Regexp::Parser.parse still does not and will not support streaming
  • improved performance of Subexpression#each_expression
  • minor improvements to Regexp::Scanner performance
  • overall improvement of parse performance: about 10% for large Regexps

Fixed

  • parsing of octal escape sequences in sets, e.g. [\141]

2.6.2 (from changelog)

Fixed

  • fixed SystemStackError when cloning recursive subexpression calls
    • e.g. Regexp::Parser.parse(/a|b\g<0>/).dup

2.6.1 (from changelog)

Fixed

  • fixed scanning of two negative lookbehind edge cases
    • (?<!x)y> used to raise a ScannerError
    • (?<!x>)y used to be misinterpreted as a named group
    • thanks to Sergio Medina for the report

2.6.0 (from changelog)

Fixed

  • fixed #referenced_expression for \g<0> (was nil, is now the Root exp)
  • fixed #reference, #referenced_expression for recursion level backrefs
    • e.g. (a)(b)\k<-1+1>
    • #referenced_expression was nil, now it is the correct Group exp
  • detect and raise for two more syntax errors when parsing String input
    • quantification of option switches (e.g. (?i)+)
    • invalid references (e.g. /\k<1>/)
    • these are a SyntaxError in Ruby, so could only be passed as a String

Added

  • Regexp::Expression::Base#human_name
    • returns a nice, human-readable description of the expression
  • Regexp::Expression::Base#optional?
    • returns true if the expression is quantified accordingly (e.g. with *, {,n})
  • added a deprecation warning when calling #to_re on set members

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.18.0 → 1.27.0) · Repo · Changelog

Release Notes

1.27.0 (from changelog)

New features

  • #229: Add source_range method to NodePattern. (@koic)

1.26.0 (from changelog)

New features

  • #255: Make Node#class_constructor? aware of Ruby 3.2's Data.define. (@koic)
  • #255: Make Node#class_construcor? aware of Ruby 2.7's numbered parameters. (@koic)

1.25.0 (from changelog)

New features

  • #256: Support Parser::Ruby33 for Ruby 3.3 parser (experimental). (@koic)

1.24.0 (from changelog)

New features

  • #245: Add node types forwarded_restarg and forwarded_kwrestarg. (@ydah)

1.23.0 (from changelog)

New features

  • #242: Add character_literal? to StrNode. (@koic)

1.22.0 (from changelog)

New features

  • #240: Add a type predicate new_line? to Token. (@tdeo)

1.21.0 (from changelog)

New features

1.20.1 (from changelog)

New features

1.20.0 (from changelog)

Bug fixes

  • #230: Make RegexpNode aware of fixed-encoding regopt. (@koic)

1.19.1 (from changelog)

New features

  • #235: Add regexp_dots? method to RuboCop::AST::Token (erroneously released in 1.19.0 as regexp_dot?). (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ ruby-progressbar (indirect, 1.11.0 → 1.13.0) · Repo · Changelog

Release Notes

1.13.0 (from changelog)

Add

  • Ability To Allow Different Projectors To Be Used For Time Estimates
  • Concept Of A Projector
  • Ability To Access Progress Bar Instance Using Enumerator Refinement

Remove

  • smoothing Option

Change

  • Issue Caused By Ruby Bug

1.12.0 (from changelog)

Add

  • Ability To Swap Out Running Average Calculators
  • running_average_rate As Configuration Option
  • Wall Clock Time To Completion To The Format Elements

Change

  • Rename Running Average Calculator To Smoothed Average Calculator
  • Rename smoothing To running_average_rate
  • Rename smoothing_factor To rate
  • Allow Timer's Elapsed Seconds To Calculate Even If Not Started

Does any of this look wrong? Please let us know.

↗️ tzinfo (indirect, 2.0.5 → 2.0.6) · Repo · Changelog

Release Notes

2.0.6

  • Eliminate Object#untaint deprecation warnings on JRuby 9.4.0.0. #145.

TZInfo v2.0.6 on RubyGems.org

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ unicode-display_width (indirect, 2.2.0 → 2.4.2) · Repo · Changelog

Release Notes

2.4.2 (from changelog)

More performance improvements:

  • Optimize lookup of first 4096 codepoints
  • Avoid overwrite lookup if no overwrites are set

2.4.1 (from changelog)

  • Improve general performance!
  • Further improve performance for ASCII strings

You should really upgrade - it's much faster now!

2.4.0 (from changelog)

  • Improve performance for ASCII-only strings, by @fatkodima
  • Require Ruby 2.4

2.3.0 (from changelog)

  • Unicode 15.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added the depfu Automatic PRs to update gems label Mar 4, 2023
@depfu depfu bot force-pushed the depfu/update/rubocop-rails-2.18.0 branch from fae6c90 to cba81c1 Compare March 21, 2023 14:30
@depfu
Copy link
Contributor Author

depfu bot commented Apr 14, 2023

Closed in favor of #3155.

@depfu depfu bot closed this Apr 14, 2023
@depfu depfu bot deleted the depfu/update/rubocop-rails-2.18.0 branch April 14, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depfu Automatic PRs to update gems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants