Enable support for heterogeneous data and expose max_resolution_3d
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `OpenPMDTimeSeries` is modified to support cases where not all iterations contain the same records (i.e., fields and species)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I'm in the process of making the VisualPIC backend fully rely on the
OpenPMDTimeSeries(AngelFP/VisualPIC#57). This will make it easier to maintain and avoid code duplication. In order to do this, this PR ports a couple of features from VisualPIC to the viewer:openPMDseries where each iteration can have different fields and species than the others. Until now, theOpenPMDTimeSerieswould simply raise a warning.sliderto support the case above.max_resolution_3dparameter in theget_fieldmethod (until now it was only available in theDataReader).