Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions to measure phase points #257

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Functions to measure phase points #257

wants to merge 4 commits into from

Conversation

mingzeng8
Copy link

Add functions to measure phase points of axial E_z field.

@mingzeng8
Functions to measure phase points
0c65e84 
Add functions to measure phase points of E_z field.
@RemiLehe
Copy link
Member

RemiLehe commented Jan 6, 2020

Thanks for this pull request!
However, at this point I am not sure that I fully understand the purpose of the changes. Could you edit the description above in order to explain the new functionality in more details?

Also, note that pyflakes raised an error here. Could you fix the issue and update the pull request? (You can git push to the same branch and this will automatically update the pull request)

Thanks a lot!

@ax3l ax3l added the feature label Jan 6, 2020
@mingzeng7
A new feature to measure the locations of 6 points of axial Ez field:
3bab165 
 - The point with the first E_z exceeding a threshold
 - The first maximum of E_z
 - The first zero-crossing of E_z
 - The first minimum of E_z
 - The second zero-crossing of E_z
 - The second maximum of E_z

This feature can be used for the measurement of the phase velocity of the wake.
@mingzeng7
Remove the local variable 'len_xaxis' which is not used.
8cd7bfa
@mingzeng8
Copy link
Author

Thanks for your review.
I accidentally worked on an older branch. Now I moved everything to the latest dev branch and it works well.
But I'm not sure what are the failures in the checks. Actually I ran the same check on my local machine and it has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mingzeng8 @RemiLehe @ax3l @mingzeng7