Add midi beat event #313
Open
Add midi beat event #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvengen
commented
Jun 22, 2020
wvengen
commented
Jun 22, 2020
|
Thanks for your feedback and explanation! I'll change the ringbuffer issue you mentioned, will try to do so this year still. |
wvengen
force-pushed
the
feature/midi-beat
branch
from
f0efd04
to
368f4b9
Compare
harryhaaren
approved these changes
Feb 20, 2022
There was a problem hiding this comment.
Hi @wvengen, reviewed these changes, they look good to me but I have not tested them. Any last comments, or are you OK with me clicking the big green MERGE?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #124.
Depends on PR #311, for this PR only the last commit here is relevant.
See also #124 (comment) for usage.