Fix clip sync #284
Open
Fix clip sync #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit calculates the play speed for a looperclip based on the frames per beat, this avoids displacement due to different clip length Also there was a wrong clip reset when the playhead gets reset in getSample because of the end of buffer. This is not really a nice fix but works for further testing of clipsync
The user should be fully responsible for the speed of the tempo change, therefore no smoothing should be applied.
This makes it much easier to set a specific tempo since the DSP engine does not set a value while the knob is clicked. The result were jumps while changing tempo which should be resolved now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to change the tempo on the fly again (without pitch correction)