[receiver/vcenter] Switches Over Metadata Configs Waiting for v0.100.0 Release #32913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
approved these changes
May 8, 2024
djaglowski
reviewed
May 8, 2024
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
There was a problem hiding this comment.
Can you add a note here which details the specific resource attributes and metrics which are now enabled by default?
StefanKurek
force-pushed
the
feat/vcenterreceiver-switch-configs
branch
2 times, most recently
from
26bf9d3
to
ceddf89
Compare
StefanKurek
force-pushed
the
feat/vcenterreceiver-switch-configs
branch
from
ceddf89
to
6efece1
Compare
djaglowski
approved these changes
May 8, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…0 Release (open-telemetry#32913) **Description:** <Describe what has changed.> A number of configurations were disabled by default and had warnings that they were going to be enabled in v0.101.0 (1 metric had a warning that it was going to be removed). Now that v0.100.0 has been release, I have removed all of these warnings, and made the modifications that the warnings "warned" about. I have also updated the tests to reflect this. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#32803 open-telemetry#32805 open-telemetry#32821 open-telemetry#32531 open-telemetry#32557 **Testing:** <Describe what testing was performed and which tests were added.> Unit/integration tests updated and tested. Local environment tested. **Documentation:** <Describe the documentation added.> New documentation generated based on the metadata.
djaglowski
pushed a commit
that referenced
this pull request
May 10, 2024
…esults (#32987) **Description:** <Describe what has changed.> In this [PR](#32913), I accidentally removed all the enabled configs from the 2nd set of unit tests. This was incorrect as there are still 4 of them that are currently disabled by default. This is rectifying that by adding those back in. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> This change is for the unit tests only **Documentation:** <Describe the documentation added.> NA
jlg-io
pushed a commit
to jlg-io/opentelemetry-collector-contrib
that referenced
this pull request
May 14, 2024
…0 Release (open-telemetry#32913) **Description:** <Describe what has changed.> A number of configurations were disabled by default and had warnings that they were going to be enabled in v0.101.0 (1 metric had a warning that it was going to be removed). Now that v0.100.0 has been release, I have removed all of these warnings, and made the modifications that the warnings "warned" about. I have also updated the tests to reflect this. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#32803 open-telemetry#32805 open-telemetry#32821 open-telemetry#32531 open-telemetry#32557 **Testing:** <Describe what testing was performed and which tests were added.> Unit/integration tests updated and tested. Local environment tested. **Documentation:** <Describe the documentation added.> New documentation generated based on the metadata.
jlg-io
pushed a commit
to jlg-io/opentelemetry-collector-contrib
that referenced
this pull request
May 14, 2024
…esults (open-telemetry#32987) **Description:** <Describe what has changed.> In this [PR](open-telemetry#32913), I accidentally removed all the enabled configs from the 2nd set of unit tests. This was incorrect as there are still 4 of them that are currently disabled by default. This is rectifying that by adding those back in. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> This change is for the unit tests only **Documentation:** <Describe the documentation added.> NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A number of configurations were disabled by default and had warnings that they were going to be enabled in v0.101.0 (1 metric had a warning that it was going to be removed).
Now that v0.100.0 has been release, I have removed all of these warnings, and made the modifications that the warnings "warned" about. I have also updated the tests to reflect this.
Link to tracking Issue:
#32803 #32805 #32821 #32531 #32557
Testing:
Unit/integration tests updated and tested. Local environment tested.
Documentation:
New documentation generated based on the metadata.