Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/vcenter] vcenter.cluster.memory.used Not Implemented #32805

Closed
StefanKurek opened this issue May 1, 2024 · 1 comment
Closed

[receiver/vcenter] vcenter.cluster.memory.used Not Implemented #32805

StefanKurek opened this issue May 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@StefanKurek
Copy link
Contributor

Component(s)

receiver/vcenter

What happened?

Description

Currently, the vcenter.cluster.memory.used is not actually implemented. I verified this by looking at the code.

Steps to Reproduce

Collect against any vCenter environment with an active Cluster.

Expected Result

See the vcenter.cluster.memory.used metric returned for Cluster resources.

Actual Result

No vcenter.cluster.memory.used metric returned for Cluster resources.

Collector version

v1.6.0/v0.99.0

Environment information

No response

OpenTelemetry Collector configuration

extensions:
  basicauth/prom:
    client_auth:
      username: [PROMUSER]
      password: [PROMPASS]

exporters:
  prometheusremotewrite:
    endpoint: [PROMENDPOINT]
    auth:
      authenticator: basicauth/prom
    resource_to_telemetry_conversion:
      enabled: true # Convert resource attributes to metric labels

processors:
  batch:
    # https://github.com/open-telemetry/opentelemetry-collector/tree/main/processor/batchprocessor

receivers:
  vcenter:
    endpoint: https://[VCENTERHOST]
    username: [VCENTERUSER]
    password: [VCENTERPASS]
    tls:
      insecure: true
    collection_interval: 1m
    initial_delay: 1s

service:
  extensions: [basicauth/prom]
  pipelines:
    metrics:
      receivers: [vcenter]
      processors: [batch]
      exporters: [prometheusremotewrite]

Log output

No response

Additional context

No response

@StefanKurek StefanKurek added bug Something isn't working needs triage New item requiring triage labels May 1, 2024
@StefanKurek
Copy link
Contributor Author

@djaglowski planning on just gutting this metric ultimately. It doesn't have direct metrics to pull from the API to grab/calculate it. It also doesn't have a CPU equivalent for a Cluster either.

I'll start with adding a warning to the metric about future removal, with a followup PR actually removing it.

@djaglowski djaglowski removed the needs triage New item requiring triage label May 1, 2024
djaglowski pushed a commit that referenced this issue May 2, 2024
…g With Warning (#32807)

**Description:** <Describe what has changed.>
This metric is not actually implemented. Adding a warning for now if a
user has it configured in some way to let them know that it'll be going
away soon.

**Link to tracking Issue:** <Issue number if applicable>
#32805 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
N/A
djaglowski pushed a commit that referenced this issue May 8, 2024
…0 Release (#32913)

**Description:** <Describe what has changed.>
A number of configurations were disabled by default and had warnings
that they were going to be enabled in v0.101.0 (1 metric had a warning
that it was going to be removed).

Now that v0.100.0 has been release, I have removed all of these
warnings, and made the modifications that the warnings "warned" about. I
have also updated the tests to reflect this.

**Link to tracking Issue:** <Issue number if applicable>
#32803 #32805 #32821 #32531 #32557

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
…g With Warning (open-telemetry#32807)

**Description:** <Describe what has changed.>
This metric is not actually implemented. Adding a warning for now if a
user has it configured in some way to let them know that it'll be going
away soon.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32805 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
N/A
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this issue May 8, 2024
…0 Release (open-telemetry#32913)

**Description:** <Describe what has changed.>
A number of configurations were disabled by default and had warnings
that they were going to be enabled in v0.101.0 (1 metric had a warning
that it was going to be removed).

Now that v0.100.0 has been release, I have removed all of these
warnings, and made the modifications that the warnings "warned" about. I
have also updated the tests to reflect this.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32803 open-telemetry#32805 open-telemetry#32821 open-telemetry#32531 open-telemetry#32557

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
jlg-io pushed a commit to jlg-io/opentelemetry-collector-contrib that referenced this issue May 14, 2024
…g With Warning (open-telemetry#32807)

**Description:** <Describe what has changed.>
This metric is not actually implemented. Adding a warning for now if a
user has it configured in some way to let them know that it'll be going
away soon.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32805 

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
N/A
jlg-io pushed a commit to jlg-io/opentelemetry-collector-contrib that referenced this issue May 14, 2024
…0 Release (open-telemetry#32913)

**Description:** <Describe what has changed.>
A number of configurations were disabled by default and had warnings
that they were going to be enabled in v0.101.0 (1 metric had a warning
that it was going to be removed).

Now that v0.100.0 has been release, I have removed all of these
warnings, and made the modifications that the warnings "warned" about. I
have also updated the tests to reflect this.

**Link to tracking Issue:** <Issue number if applicable>
open-telemetry#32803 open-telemetry#32805 open-telemetry#32821 open-telemetry#32531 open-telemetry#32557

**Testing:** <Describe what testing was performed and which tests were
added.>
Unit/integration tests updated and tested. Local environment tested.

**Documentation:** <Describe the documentation added.>
New documentation generated based on the metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants