Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hammer/demo tasks #925

Open
wants to merge 15 commits into
base: deploy/hammer
Choose a base branch
from
Open

Hammer/demo tasks #925

wants to merge 15 commits into from

Conversation

aaronchongth
Copy link
Member

@aaronchongth aaronchongth commented Mar 28, 2024

What's new

  • Introduced patrol, delivery and clean back
  • Refactored each task to it's own file to handle its own description and form
  • Configurable list of supported tasks, order of task is respected in the menu
  • Task name remapping

Here is how the rmf-web/packages/dashboard/src/assets/resources/main.json can look like,

{
    ...,
    "supportedTasks": [
        {
            "name": "delivery",
            "nameRemap": "I'm reaching out about your extended car warranty"
        },
        {
            "name": "patrol",
            "nameRemap": "Meta Patrol"
        },
        {
            "name": "clean"
        },
        {
            "name": "delivery_pickup"
        }
    ]
    ...
}

image

image

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 9.66767% with 299 lines in your changes missing coverage. Please review.

Project coverage is 26.37%. Comparing base (fe0e808) to head (eb9aeda).
Report is 89 commits behind head on deploy/hammer.

Current head eb9aeda differs from pull request most recent head 1edb5e9

Please upload reports for the commit 1edb5e9 to get more accurate results.

Files Patch % Lines
...act-components/lib/tasks/types/delivery-custom.tsx 23.07% 100 Missing ⚠️
...ackages/react-components/lib/tasks/create-task.tsx 0.00% 57 Missing ⚠️
...ckages/react-components/lib/tasks/types/patrol.tsx 2.70% 36 Missing ⚠️
packages/react-components/lib/tasks/types/utils.ts 0.00% 29 Missing ⚠️
...act-components/lib/tasks/types/delivery-simple.tsx 0.00% 28 Missing ⚠️
...ackages/react-components/lib/tasks/types/clean.tsx 0.00% 24 Missing ⚠️
...eact-components/lib/tasks/types/custom-compose.tsx 6.25% 15 Missing ⚠️
...hboard/src/components/tasks/task-schedule-utils.ts 0.00% 8 Missing ⚠️
...s/dashboard/src/components/tasks/task-schedule.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           deploy/hammer     #925       +/-   ##
==================================================
- Coverage          49.35%   26.37%   -22.99%     
==================================================
  Files                285      163      -122     
  Lines               7564     5377     -2187     
  Branches            1050     1419      +369     
==================================================
- Hits                3733     1418     -2315     
- Misses              3682     3760       +78     
- Partials             149      199       +50     
Flag Coverage Δ
api-server ?
dashboard 13.70% <0.00%> (-1.37%) ⬇️
react-components 42.61% <9.96%> (-5.47%) ⬇️
rmf-auth ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
packages/react-components/lib/tasks/types/utils.ts Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/types/clean.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
packages/react-components/lib/tasks/create-task.tsx Outdated Show resolved Hide resolved
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@aaronchongth aaronchongth marked this pull request as ready for review June 4, 2024 09:14
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants