Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean tasks now submit a sequence of goto and perform_action #643

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clean tasks now submit a sequence of goto and perform_action #643

wants to merge 2 commits into from

Conversation

aaronchongth
Copy link
Member

Signed-off-by: Aaron Chong aaronchongth@gmail.com

What's new

Implements #639. This will require changes on other Open-RMF packages related to cleaning tasks.

Self-checks

  • I have prototyped this new feature (if necessary) on Figma
  • I'm familiar with and follow this Typescript guideline
  • I added unit-tests for new components
  • I tried testing edge cases
  • I tested the behavior of the components that interact with the backend, with an e2e test

Discussion

aaronchongth and others added 2 commits September 27, 2022 00:36
@aaronchongth
Clean tasks now submit a sequence of goto and perform_action
faea601 
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
@xiyuoh
Change clean task category to compose
d4c3a13 
Signed-off-by: Xi Yu Oh <xiyu@openrobotics.org>
@xiyuoh xiyuoh mentioned this pull request Sep 30, 2022
Closed
@aaronchongth aaronchongth marked this pull request as ready for review October 21, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaronchongth @xiyuoh