Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codecamp: mmpose-529]Add the new config of the adaptive attitude estimation algorithm DARK #2639

Open
wants to merge 3 commits into
base: dev-1.x
Choose a base branch
from

Conversation

kingyaaa
Copy link

Motivation

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@kingyaaa
Copy link
Author

在进行pre-commit检查时是全部passed的,但是进行pr提交的CI测试则会产生failed

@Tau-J
Copy link
Collaborator

Tau-J commented Aug 22, 2023

@kingyaaa 你好,第一次pre-commit会自动修正代码格式,这个时候需要再git add和commit一下,可以改动文件后再尝试一次。新的config请不要用new_config.py命名,请按照和旧版本 configs 文件路径下一样的目录结构和命名方式来组织。

PR 代码请提交到 dev-1.x分支,我已帮你切换,但是你fork的代码版本已落后与官方分支,请按照下面的指令更新一下你的本地分支:

# 切换到你 fork 的 dev-1.x
git checkout dev-1.x

# 拉取最新的 dev-1.x
git pull upstream dev-1.x

# 切换回你的 pr 分支
git checkout kingyaaa/mmpose-529

# rebase dev-1.x
git rebase dev-1.x

# push 更新你的 pr
git push origin  kingyaaa/mmpose-529 -f

@Tau-J Tau-J changed the base branch from main to dev-1.x August 22, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants