Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Devide-and-integerize operation for torch.Tensor #1290

Open
wants to merge 3 commits into
base: dev-0.26
Choose a base branch
from

Conversation

wusize
Copy link
Collaborator

@wusize wusize commented Apr 4, 2022

Motivation

Resolve pytorch warning in voxelpose_head.py for divison operation.

Modification

BC-breaking (Optional)

Use cases (Optional)

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Apr 4, 2022

CLA assistant check
All committers have signed the CLA.

@wusize wusize requested a review from jin-s13 April 4, 2022 06:14
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
mmpose/models/heads/voxelpose_head.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!

@wusize wusize changed the title 'voxelpose_head.py' DevideAndIntegerize Apr 4, 2022
@wusize wusize changed the title DevideAndIntegerize Devide-and-integerize operation for torch.Tensor Apr 4, 2022
@ly015 ly015 changed the base branch from master to dev-0.26 April 5, 2022 09:47
@ly015 ly015 changed the title Devide-and-integerize operation for torch.Tensor [Fix] Devide-and-integerize operation for torch.Tensor Apr 5, 2022
@ly015
Copy link
Member

ly015 commented Apr 5, 2022

Could you please also check if this issue exists in other parts of mmpose?

@wusize
Copy link
Collaborator Author

wusize commented Apr 6, 2022

Could you please also check if this issue exists in other parts of mmpose?

Ok.

@ly015
Copy link
Member

ly015 commented Apr 15, 2022

@wusize CI failed. Please check the reason.

@jin-s13 jin-s13 added the status/blocked blocked by upstream or other issues label Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/blocked blocked by upstream or other issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants