Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving issue #11362. Creating nltk_data in the $HOME directory. #11488

Open
wants to merge 4 commits into
base: dev-3.x
Choose a base branch
from

Conversation

javierganan99
Copy link

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The motivation is to solve issue #11362. NLTK default download creates a weird folder in the project directory level named ~/nltk_data, when it seems the intention is to create this at the $HOME directory.

Modification

I solve this issue using os library to efectively substitute ~ by $HOME directory. I modify it in the code and also in the related documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2024

CLA assistant check
All committers have signed the CLA.

@hhaAndroid hhaAndroid changed the base branch from main to dev-3.x February 23, 2024 09:10
@hhaAndroid
Copy link
Collaborator

@javierganan99 Please fix the lint

@javierganan99
Copy link
Author

I think that the error in the unittest is not related with my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants