Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SDK-250): denylist bot #115

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(SDK-250): denylist bot #115

wants to merge 13 commits into from

Conversation

1Mateus
Copy link
Collaborator

@1Mateus 1Mateus commented Apr 10, 2023

URL to Jira task (this should explain the task)

https://hackachain.atlassian.net/browse/HYC-205?atlOrigin=eyJpIjoiYzJjMGIwYTNkYjRjNDMyNjg3NDAzNzM5YTg0ZTI3ZTYiLCJwIjoiaiJ9

Explain what the code alterations do

create new denylist bot

What has to be tested? How to test it?

execute yarn denylist test

Any new dependencies? Why were they added?

new denylist packages

Copy link
Collaborator

@veigajoao veigajoao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is looking really solid. I pointed out a couple issues with the implementation that were not verified in tests.

Also pointed out some readability issues and improvements.

Please let me know how you feel about them before implementing.

packages/contracts/tests-ts/src/constants/merkle-tree.ts Outdated Show resolved Hide resolved
packages/front/src/hooks/useEnv.tsx Outdated Show resolved Hide resolved
packages/denylist-bot/src/utils.ts Outdated Show resolved Hide resolved
packages/denylist-bot/src/services/consumer.ts Outdated Show resolved Hide resolved
packages/denylist-bot/src/services/consumer.ts Outdated Show resolved Hide resolved
packages/denylist-bot/src/services/consumer.ts Outdated Show resolved Hide resolved
packages/denylist-bot/src/services/consumer.ts Outdated Show resolved Hide resolved
@1Mateus 1Mateus requested a review from veigajoao April 13, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants