Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Duplicated text for RTL languages #54

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

VitalikL
Copy link

Addressing #33

This is not the cleanest solution, as it uses specific calculation for the X coordinate when isRTL. Also, it does not address the issue of the animation for RTL

@johan12345
Copy link
Contributor

Thank you for your Pull request! I just tested your version using the text that you tested in #33. The expanded state looks good, but as you said, the animation is not really complete and also, the text seems to have a wrong position (too low) in the collapsed state:
device-2018-03-01-222949

Would you like to continue to work on this so that we can have one PR that fixes all RTL problems?

@VitalikL
Copy link
Author

VitalikL commented Mar 1, 2018

Thanks @johan12345. It is strange that the text is very low in collapsed state, since the change introduced here is only for horizontal positioning of expanded caption. I will test master version later to see if this is a regression

@johan12345
Copy link
Contributor

Hey, we are currently trying to get the multiline feature merged into the official Material Components library (see the PR). However, for that, we need to make the animation work correctly in RTL languages. I tried to fix it, but so far I haven't found out how. Would you be interested in helping us with that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants