Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ml opset version that is saved by default without --extra_opset and --custom-ops #2205

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

inzapp
Copy link

@inzapp inzapp commented Jul 14, 2023

Remove ml version opset that is stored by default without using two flags(--extra_opset, --custom-ops)

This additional ml version opset can cause problems with converting for model serving for various edge devices

If additional ml version offset is required, add it via --extra_opset or --custom-ops

…opset and --custom-ops

Signed-off-by: inzapp <inzapp@naver.com>
@fatcat-z
Copy link
Collaborator

Directly removing it will cause other problem which has been covered by tests. Suggest to add a judgement around it so if extra_opset or custom-ops was specified, then skip this default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants