rfcs: graph api: propose ocl runtime support #1821
Conversation
| API. | ||
| - oneDNN OpenCL interop API supports creating engine from a cache blob. This is | ||
| not considered in this RFC as the requirement and use scenario for graph API | ||
| is not clear at this moment. |
There was a problem hiding this comment.
Creating engine from a cache is added to reduce the engine creation time. Otherwise, we had several hundred milliseconds additional overhead. OV expects engine creation for graph api to be fast, too.
There was a problem hiding this comment.
Thank you for the comment, @isanghao . This limitation is removed in the second commit.
| - Primitive selection (`DNNL_ENABLE_PRIMITIVE`) and workload selection | ||
| (`DNNL_ENABLE_WORKLOAD`) are not supported by Graph API as before. We mention | ||
| them here as the features were initially requested by OpenVINO for primitive | ||
| API. |
There was a problem hiding this comment.
What about the binary size impact of enabling graph api? This configs are added because we are constantly pushed for smaller binary size.
There was a problem hiding this comment.
For dynamic library, enabling Graph API (-DONEDNN_BUILD_GRAPH=ON) increases ~4MB to the binary size. It's almost constant over different CPU/GPU runtime combinations as the implementation code is general.
For example, a typical default build (CPU_RUNTIME=OMP/GPU_RUNTIME=NONE) with GCC 11.4 on my Ubuntu machine. The binary size of libdnnl.so is increased from 59710128 Bytes to 64126976 Bytes with Graph API enabled.
TaoLv
force-pushed
the
lvtao/rfc/graph-ocl
branch
2 times, most recently
from
9c98df6
to
fc2e31d
Compare
This is to propose adding OpenCL GPU runtime support in oneDNN Graph API.
It addresses the API limitations mentioned RFC #1745 and also paves the way for OpenVINO integration.