chore: cleanup coveralls/simplecov setup #1120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
force-pushed
the
simplecov-cleanup
branch
from
3e10d55
to
125f854
Compare
|
This doesn't fix the JRuby failures, but it get's rid of some unrelated errors like https://github.com/omniauth/omniauth/actions/runs/5125273149/jobs/9218237165?pr=1119#step:4:210 when it tries to load some of that stuff at the end of the runs |
nschonni
force-pushed
the
simplecov-cleanup
branch
from
125f854
to
70af4d1
Compare
The coveralls_reborn mentions that the gem isn't needed for Actions. Followed setup from coverallsapp/github-action#29 (comment)
nschonni
force-pushed
the
simplecov-cleanup
branch
from
b2c50b3
to
e25e7fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The coveralls_reborn mentions that the gem isn't needed for Actions.
Followed setup from coverallsapp/github-action#29 (comment)