Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank loss in tournament #494

Merged
merged 4 commits into from Jul 27, 2023
Merged

Rank loss in tournament #494

merged 4 commits into from Jul 27, 2023

Conversation

gdeda
Copy link
Contributor

@gdeda gdeda commented Jul 20, 2023

This makes the player to lose a rank position in the tournament when a match is lost.
A check is added to avoid going out of the array list of ranked participants if the player loses the match while being already at the bottom of the ladder.

@gdeda
Copy link
Contributor Author

gdeda commented Jul 20, 2023

NOTE: will work only in OMF tournaments, not in custom tournaments
EDIT: ignore, I'm stupid with operators. Did another commit and revised the indentation (i'm not sure what clang has to argue)
EDIT 2: ok, did a clang-format run

@katajakasa
Copy link
Member

I'm not close to my dev pc so cannot test this now, but it seems good so I'm just going to trust you and merge it ;)

@katajakasa katajakasa merged commit 4287067 into omf2097:master Jul 27, 2023
7 checks passed
@Vagabond
Copy link
Member

does seem reasonable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants