Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memwriter #414

Merged
merged 2 commits into from Nov 9, 2021
Merged

Memwriter #414

merged 2 commits into from Nov 9, 2021

Conversation

mrannanj
Copy link
Contributor

@mrannanj mrannanj commented Nov 7, 2021

@katajakasa
Copy link
Member

Seems fine to me. I will read this through in more detail tomorrow, but if nothing shows up, I think I will just go ahead and merge.

@mrannanj
Copy link
Contributor Author

mrannanj commented Nov 9, 2021

Seems fine to me. I will read this through in more detail tomorrow, but if nothing shows up, I think I will just go ahead and merge.

The ticket said to also look for places where const could be added, but these commits only do the rename.

@katajakasa
Copy link
Member

The ticket said to also look for places where const could be added, but these commits only do the rename.

Yup, that's fine. I like when people make things in small, manageable pieces :)

Also, went through it, nothing jumped at my face immediately.

@katajakasa katajakasa merged commit 3d8b2eb into omf2097:master Nov 9, 2021
@mrannanj mrannanj deleted the memwriter branch November 9, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrannanj @katajakasa