Use all available cores #781
Conversation
When determining what cores are available, we should use the total number from the system, not from the current process
|
Can one of the admins verify this patch? |
| @@ -99,7 +100,7 @@ else: | |||
|
|
|||
|
|
|||
| # Initialize workers | |||
| cores = get_process_affinity() | |||
There was a problem hiding this comment.
Given that with this change the get_process_affinity function is not used anymore, should it be removed from utils.py?
There was a problem hiding this comment.
Excellent point. I was not sure about if it could have been used elsewhere without me knowing it.
There was a problem hiding this comment.
I do not see it used anywhere else
|
@markbeierl, have you tested the behavior of this PR when deploying multiple UPF instances in the same host? |
|
Yes, I have tested it, and repeated tests show my affinity staying at |
|
Although, to note, we have no method of controlling the UPFs affinity when there is more than one on the physical host, so they both fight for processor 0 in that case. |
When determining what cores are available, we should use the total number from the system, not from the current process
Addresses #780