Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testSaneUsedFiles: check getCurrentFile is the first file in the getUsedFiles list #4172

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Mar 25, 2024

Discussed earlier with @melissalinkert and @jburel, opening initially to assess how many formats deviate from this assumption in the nightly CI builds

@sbesson sbesson force-pushed the getcurrentfile_getusedfiles branch from 2a60d54 to ca66ec1 Compare March 25, 2024 22:21
@sbesson sbesson marked this pull request as draft March 26, 2024 09:32
@sbesson
Copy link
Member Author

sbesson commented Mar 26, 2024

As expected, quite a few failures reported in the nightly CI builds. The reader for the following curated QA folders should likely be reviewed as a next step:

  • biorad
  • metamorph
  • flex
  • cellsens
  • ultraview
  • fuji
  • micromanager
  • perkinelmer
  • bdv
  • zeiss-tiff
  • scanr

Marking this PR as draft in the meantime

@sbesson sbesson added this to the 8.0.0 milestone Apr 8, 2024
@sbesson
Copy link
Member Author

sbesson commented Apr 8, 2024

As discussed today, assigning to the 8.0.0 milestone with the aim to:
1- review and update the contract of IFormatReader to enforce consistency between getCurrentFile and getUsedFiles
2- review and update all the readers for the failing formats

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant