Add failing test case for #153 #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been investigating a bug that occurs when a ClassExpression is using the experimental class properties for propTypes. I am not sure what the best fix for it is yet, but I wanted to get up a failing test case to help showcase the bug.
We are already supporting it this use case. The logic I wrote is inspired by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been investigating a bug that occurs when a ClassExpression is
using the experimental class properties for propTypes. I am not sure
what the best fix for it is yet, but I wanted to get up a failing test
case to help showcase the bug.
@oliviertassinari do you have any ideas on how static class propTypes
properties can be removed from ClassExpressions in wrap mode?
Related to #153