refactor(Application Search): Improve Linux compatibility #1097
+272
−105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
LinuxAppIconExtractor
to use sharp instead of callingconvert
on the command line as some Linux distros (notably Linux Mint) does not come with theconvert
package installed by default.LaunchDesktopFile
to usegio launch
as it appears to be installed on all Linux distros I tested (even KDE based ones)@oliverschwendener I import
sharp
directly inLinuxAppIconExtractor
. Let me know if you'd like me to create a module to handle image conversion. I'm also unfamiliar with electron-builder so I'm not sure if asar is the best way to handle packagingsharp
(it wouldn't bundle without it)