Node system overhaul for better flexibility and usability #2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems to work reasonably well. Is missing loop modes. Some codecs produce artifacts.
|
creating a vec value node crashes olive on windows, vec2/3/4 all pose issue |
In retrospect, this was premature and poorly done. It's been reverted with potential for library building later on.
|
Is it normal that a project generated with the version in master does not load with the version compiled with this branch? |
|
The latest commit indicates FFMPEG minimal version at 5.0, but the code uses symbol swr_alloc_set_opts2 (with ending '2')that is not present in 5.0 interface. If I'm not wrong, it has been introduced in 5.1. |
|
not able to compile on windows or linux |
Glad to see that I'm not the only one. In order to compile, I added "#include <cmath>" in several files. |
Can you please list the specific files you added the "#include " to? Thanks. |
This is the list of files in which I have added "#include <cmath>: app/audio/audiovisualwaveform.cpp |
|
Thanks so much. I'll give it a try on MacOS Ventura. |
|
This is a patch I use to fix building on windows |
Which version of FFMPEG did you use? |
on windows I am using msys so ffmpeg 6.0, Just tested on linux earlier on ffmpeg-git thats about a week old or two, for that you need to patch -find_package(FFMPEG 3.0 REQUIRED
+find_package(FFMPEG REQUIRED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get features we've wanted for a long time, it became necessary to overhaul the node architecture once again. While I often don't create PRs for my own branches (though I probably should get into the habit), I'm doing so with this because it introduces so many sweeping changes, that it has almost certainly introduced bugs/crashes/incompatibilities that should be resolved before we merge to master. I've also been holding off on making too many changes to
mastersince my focus was on this and I wanted to ensure a smooth merge.The new additions in this branch are:
Like I said, this is still probably fairly unstable and not everything is complete, but I'm working on getting it up to speed.