Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RGB to B&W node #1920

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ThomasWilshaw
Copy link
Collaborator

Implements a RGB to B&W node using OCIO luma coefficients. ALso allows for overriding these with custom weights. There's a few questions in the code comments.

Specifically is there a good way to have coloured sliders be disabled and greyed out? I feel my solution is not ideal. Also I've tried to cache the luma coefficients but I can't seem to get it to work properly.

@sobotka
Copy link
Collaborator

sobotka commented May 10, 2022

Not sure if you do this with this patch, but it may be wise to expose the weights and fill them with the default as determined. This would allow cases where folks may require alternative weighting.

@ThomasWilshaw
Copy link
Collaborator Author

Yes there's a checkbox to use custom weights included.

@ThomasWilshaw
Copy link
Collaborator Author

@itsmattkc quick question, the title of this node is RGB to B&W which displays fine in the properties viewer. However, in the drop downs (e.g. the add effect drop down) Qt uses the & as an emphasis and so it displays as "RGB to BW" with the W underlined (see image). If I use a double ampersand to correct this it displays incorrectly in the node header. What do you think the best approach is here? Just using one ampersand and living with the underline o rmaybe even just ditching the ampersand completely?

Other than that I think this is good to go.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants