Internal overhaul task #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevBefell
changed the title
DevBefell
force-pushed
the
internaloverhaul
branch
from
269f138
to
df3bd83
Compare
|
All is done except for integrity checking as that would require a lot more changes, currently finished the overhaul but need testing to assure it isn't breaking anything. |
|
In your fix for #62, do you hide only versions with "custom" release type or all modded versions? (some have release or snapshot build type) Does it affect the "latest version" option? |
|
Customs are those not in the remote list (version manifest), so those that are not releases, snapshots, old alpha and beta |
bigfoot547
force-pushed
the
internaloverhaul
branch
2 times, most recently
from
e108504
to
564597d
Compare
|
rebased to include new CI stuff |
DevBefell
force-pushed
the
internaloverhaul
branch
from
564597d
to
6842aaf
Compare
Moved authentication database, selected user and client token out of launcher profiles and into launcher accounts. Fixed issues with JVM Arguments having extra spaces. Fixed issues with game output streams being closed early and made the process "safer".
added latest snapshots latest versions based on remote not local (olauncher#62) cache version manifest for offline use add version filter settings
bigfoot547
force-pushed
the
internaloverhaul
branch
from
6842aaf
to
42863dd
Compare
|
RE: latest commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are somethings I will do within this overhaul. So far no issues with the new accounts files the other miscellaneous changes. Would be best to test out before I finish.