Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for multiple plugins #961

Merged
merged 2 commits into from
Aug 22, 2023
Merged

Conversation

shashigharti
Copy link
Contributor

@shashigharti shashigharti commented Aug 17, 2023

Article Link

  • Add on hover / on click states (search for "Article" here)
  • Make URL field non-mandatory

Banner

  • Implement different colors for each variation (search for "Banner" here)
  • Enable markdown in the Text field

Carousel

  • Display each image's Alt text after 1 sec mouse hover

OKImage

  • When not In column, display the caption below the image, not inside
  • Change the option text from Show caption to Use caption instead of text
  • Display Alt text after 1 sec mouse hover

Feature Block

  • Add the small arrow to the "Learn more" button (gets activated when an URL is added) -- already fixed(PR Create additional plugins for lists and stats #895)
  • Yellow and Yellow background currently have the same layout. Needs to recover Yellow as the original yellow squared box (search for "Content Grid" here)
  • Add option Text white to Blue background, Yellow background, Purple background and Rounded corners
  • Add on hover / on click states to Blue background, Yellow background, Purple background and Rounded corners
  • Change type name from Yellow to Yellow Box
  • Change variant name from White to White Box

Gallery

  • Rename plugin to "Running Gallery"
  • Stop automatic scroll on mouse hover
  • Make it draggable
  • Display each image's Alt text after 1 sec mouse hover

Banner, Article Link, Gallery, Feature Block and Image
@shashigharti shashigharti requested review from avdata99 and pdelboca and removed request for avdata99 August 17, 2023 09:02
@shashigharti
Copy link
Contributor Author

For gallery I did add the params 'pauseOnHover' and 'draggable' but it does not seem to work as expected. On hover it stops but after some time and it is draggable 'only once' when the slider stops.

@shashigharti shashigharti changed the title Fix for multiple plugins Minor fixes for multiple plugins Aug 17, 2023
@pdelboca
Copy link
Member

@shashigharti agree that the draggable feature of the carousel is not working. Maybe it would be worth it to work on in in a separated PR?

@shashigharti shashigharti merged commit 3938a3c into develop Aug 22, 2023
2 checks passed
@shashigharti shashigharti deleted the 892/fix-for-multiple-plugins branch August 22, 2023 06:02
@shashigharti
Copy link
Contributor Author

shashigharti commented Aug 30, 2023

I have submitted new bug report for 'draggable' feature #977.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make minor changes to existing plugins
2 participants