Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove leftovers of AWS setup #891

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented Jul 7, 2023

As far as I understood we are no longer using AWS in the project.

This PR cleans old references to AWS code.

@avdata99 what about scripts/sync-db.sh is it still needed? It looks like it copies things from AWS to google.

@pdelboca pdelboca requested a review from avdata99 July 7, 2023 13:00
@codecov-commenter
Copy link

codecov-commenter commented Jul 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (67fe7bb) 89.36% compared to head (79695e2) 89.36%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #891   +/-   ##
========================================
  Coverage    89.36%   89.36%           
========================================
  Files          102      102           
  Lines         1552     1552           
  Branches       200      200           
========================================
  Hits          1387     1387           
  Misses         162      162           
  Partials         3        3           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@avdata99 avdata99 linked an issue Jul 7, 2023 that may be closed by this pull request
4 tasks
@avdata99 avdata99 removed a link to an issue Jul 7, 2023
4 tasks
@avdata99
Copy link
Member

avdata99 commented Jul 7, 2023

Related to #883

@avdata99
Copy link
Member

avdata99 commented Jul 7, 2023

We are using gogle secrets for test and prod environment. You can see there exactly what we are using @pdelboca
We need to cleanup also those files, we are not using AWS anymore.

As reference, test env secrets file is here

This PR looks safe

@avdata99
Copy link
Member

avdata99 commented Jul 7, 2023

We can delete the scripts/sync-db.sh script

@avdata99
Copy link
Member

avdata99 commented Jul 7, 2023

Close #607 after merging this

@avdata99 avdata99 mentioned this pull request Jul 7, 2023
@pdelboca pdelboca merged commit 4fd43ab into develop Jul 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants