Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

356 fixing editor layout #375

Merged
merged 7 commits into from
May 14, 2024
Merged

356 fixing editor layout #375

merged 7 commits into from
May 14, 2024

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented May 8, 2024

Fixes #356

This PR fixes the problem we are having in our current layout that were introduced in #327.

In this PR I'm reverting those changes in favor of refactoring the Package Layout to work smoothly with MUI Grids. I'm also using Conditional Rendering instead of disabled Box to handle the change between sections.

image

@pdelboca pdelboca requested review from guergana and roll May 8, 2024 11:07
Copy link
Collaborator

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! The app is back to normal in my env

@roll roll merged commit 0de5620 into main May 14, 2024
8 checks passed
@roll roll deleted the 356-fixing-editor-layout branch May 14, 2024 12:17
@roll
Copy link
Collaborator

roll commented May 14, 2024

MERGED to unblock #349 work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geometry problems
2 participants