Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate textfield input in "Add remote File" #374

Merged
merged 2 commits into from
May 14, 2024

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented May 7, 2024


Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

@guergana guergana changed the title Validate field in Add remote File Validate textfield input in "Add remote File" May 7, 2024
Copy link

cloudflare-pages bot commented May 7, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 645a379
Status: ✅  Deploy successful!
Preview URL: https://a53bf706.opendataeditor.pages.dev
Branch Preview URL: https://361-bug-adding-remote-file.opendataeditor.pages.dev

View logs

@guergana guergana requested review from roll and pdelboca May 7, 2024 16:49
Copy link
Member

@pdelboca pdelboca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @guergana ! Let's just change the message displayed to the user to a more descriptive one.

client/components/Parts/Dialogs/Input.tsx Outdated Show resolved Hide resolved
guergana

This comment was marked as outdated.

@guergana guergana merged commit 16c14fe into main May 14, 2024
8 checks passed
@guergana guergana deleted the 361-bug-adding-remote-file branch May 14, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when adding remote file
4 participants