Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

345 Remove bar next to the app name #372

Merged
merged 4 commits into from
May 7, 2024
Merged

345 Remove bar next to the app name #372

merged 4 commits into from
May 7, 2024

Conversation

pdelboca
Copy link
Member

@pdelboca pdelboca commented May 7, 2024

image


Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

@pdelboca pdelboca requested review from roll and guergana May 7, 2024 08:43
Copy link

cloudflare-pages bot commented May 7, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: a82b00f
Status: ✅  Deploy successful!
Preview URL: https://86ca2a26.opendataeditor.pages.dev
Branch Preview URL: https://345-remove-top-bar.opendataeditor.pages.dev

View logs

@pdelboca pdelboca requested a review from romicolman May 7, 2024 08:54
@pdelboca pdelboca marked this pull request as ready for review May 7, 2024 08:55
Copy link
Collaborator

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdelboca
You know I consider any UI changes before actual user testing sessions and UX person arrives is way preliminary. For example, the status bar contains critical information to the user:

  • file type
  • selected file path
  • a button to change the file type
  • and the whole "Create" new functionality

Also, it generally degrades the visual design of the application designed to look familiar to the users with a search bar at the top as in many modern applications like browsers/etc


But the implementation of change itself looks fine 😄

@pdelboca
Copy link
Member Author

pdelboca commented May 7, 2024

@roll I know, but this simplifies and it was requested by the PO as she considers that the only element we should have in the top navigation bar is the Valid one.

Yes, I took a look at the Create, it will get orphan until we can discuss it with the UX person.

Copy link
Collaborator

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pdelboca
That's fine. My work is to share honest opinion but the PR itself looks good

@pdelboca pdelboca merged commit 96b593c into main May 7, 2024
8 checks passed
@pdelboca pdelboca deleted the 345-remove-top-bar branch May 7, 2024 11:23
@pdelboca
Copy link
Member Author

pdelboca commented May 7, 2024

Thanks @roll !

I appreciate your comments :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove bar next to the app name
2 participants