[WiP] Selecting multiple files for deleting on left menu #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying opendataeditor with
|
| Latest commit: |
d0cabb9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://90589de4.opendataeditor.pages.dev |
| Branch Preview URL: | https://341-selecting-multiple-files.opendataeditor.pages.dev |
guergana
force-pushed
the
341-selecting-multiple-files-menu
branch
from
9f0f583
to
2b23a80
Compare
guergana
commented
Jun 2, 2024
| return ( | ||
| <InputDialog | ||
| open={true} | ||
| value={path} | ||
| value={paths[0]} |
There was a problem hiding this comment.
Not sure how moving file works. This might need to be reworked as well for multiple files
| return ( | ||
| <InputDialog | ||
| open={true} | ||
| value={path} | ||
| value={paths[0]} |
There was a problem hiding this comment.
Same as with moving files. This might need to be adjusted for multiSelection
| for (const path of paths) { | ||
| await client.fileDelete({ path }) | ||
| onFileDelete(path) | ||
| } | ||
| }, | ||
| moveFile: async (path, toPath) => { | ||
| const { client, onFileCreate } = get() | ||
| const result = await client.fileMove({ path, toPath, deduplicate: true }) |
There was a problem hiding this comment.
I don't know how this works. haven't tested it yet
| if (paths === newPaths) return | ||
| set({ paths: newPaths }) | ||
| if (!newPaths) return | ||
| if (record?.path === newPaths[0]) return |
There was a problem hiding this comment.
not sure what this is doing. using only the first path just in case. Is it for the history? Do we need to modify the record to add all the selected paths?
guergana
commented
Jun 3, 2024
| if (selectors.isFolder(get())) return | ||
| await openFile(newPath) | ||
| // if more than one file is selected, display the only the first one | ||
| if (paths && paths[0] !== newPaths[0]) await openFile(newPaths[0]) |
There was a problem hiding this comment.
This is still not working 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still TODO: make sure the first selected file is the one displayed on the View Panel. Right now it changes.