Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

315 - Change message when deleting #320

Closed
wants to merge 4 commits into from

Conversation

pdelboca
Copy link
Member

Fixes #315

image

image

Copy link

cloudflare-pages bot commented Apr 11, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7572a0e
Status: ✅  Deploy successful!
Preview URL: https://10e2f719.opendataeditor.pages.dev
Branch Preview URL: https://315-change-message-when-dele.opendataeditor.pages.dev

View logs

@pdelboca
Copy link
Member Author

pdelboca commented Apr 15, 2024

@romicolman I have some questions regarding this one. Currently we have a coherent design of < Icon + Text + [Key] > in our design so I have two questions:

  • Are we planning on removing the Icon part in all buttons? Or just in these ones?
  • Are we planning on removing the [Key] part in all buttons? Or just in these ones?

I don't want to loose the coherence of the style. Maybe we should pause the style changes until we have the UX report?

@roll
Copy link
Collaborator

roll commented Apr 16, 2024

@romicolman
BTW why would we remove keyboard shortcut documentation?

I don't want to loose the coherence of the style. Maybe we should pause the style changes until we have the UX report?

I forgot to mention it in the planning, but above is exactly what I wanted to say. Currently, all the dialogs are designed consistently regarding:

  • colors
  • button placements
  • keyboard shortcuts

There is also a complete color-coding (like blue is action, green is good, yellow is warning etc) and keyboard shortcut system (for almost all the actions and dialogs) across the whole application.

I would suggest changing it coherently, and I think it's better to do so based on User Testing sessions and after the UX-person learns the current system.

@romicolman
Copy link
Collaborator

@pdelboca / @roll Yes! I would like to avoid extra noise for the user (icon + key), but let's do this. I'll create a separate issue to check with the UX specialist before we implement changes to the ODE.

For colors, button placements and keyboard shortcuts I'll also ask Lucas to work closely to the UX person so we can adapt branding of the ODE if necessary.

@pdelboca pdelboca closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change message when deleting a file
3 participants