Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem selecting multiple files on the left menu #341

Open
romicolman opened this issue Apr 23, 2024 · 9 comments · May be fixed by #368
Open

Problem selecting multiple files on the left menu #341

romicolman opened this issue Apr 23, 2024 · 9 comments · May be fixed by #368
Assignees
Labels
feature New functionality Stable release This needs to be done for the launch stable version

Comments

@romicolman
Copy link
Collaborator

Problem description

Let's say you add a 5 files to the ODE and you want to delete a couple of them. Right now, you have to do it one by one. It is not possible to select more than one by using Ctrl + Select.

Screen:

Captura de pantalla 2024-04-23 a la(s) 22 24 03

Steps to reproduce it

  • Open the ODE.
  • Upload a couple of Csv files.
  • Try to select 3 to delete them

Suggested solution

Allow Ctrl + Select on the tool.

@romicolman romicolman added bug Something isn't working Stable release This needs to be done for the launch stable version labels Apr 23, 2024
@guergana guergana self-assigned this Apr 26, 2024
@guergana
Copy link
Collaborator

guergana commented Apr 26, 2024

Moving back to the backlog since this involves getting more familiar with the zustand store and I need more time to become familiar with it.

There is a multiSelect prop that can be passed to the TreeView component but I need more familiarity with the store to continue. I suggest @roll works on this task for now. I will get into tasks like this later on.

@guergana guergana removed their assignment Apr 26, 2024
@roll
Copy link
Collaborator

roll commented Apr 29, 2024

@romicolman
@guergana
I would call it a feature, to be honest.

@romicolman
Copy link
Collaborator Author

romicolman commented Apr 29, 2024

@roll Can you estimate how much effort this would take? I am thinking of people working on Governments who upload datasets to publish in CKAN and have several files/projects in the ODE. This is key to manage files within the tool.

Note: I replaced the bug label with feature :)

@romicolman romicolman added feature New functionality and removed bug Something isn't working labels Apr 29, 2024
@roll
Copy link
Collaborator

roll commented Apr 29, 2024

@romicolman
I think the size is 1-2 days

@romicolman
Copy link
Collaborator Author

Let's go for it! :) Can you guide @guergana to work on this?

@roll
Copy link
Collaborator

roll commented Apr 30, 2024

@guergana
@romicolman
I think it will require reworking components/Application/store.ts to support multiple active files (while not breaking the selected file logic). I've updated the Tech Effort to 3 but it might be even 5 as I see it now. Anyway, probably a good issue to get used to Zustand and TreeView

@guergana
Copy link
Collaborator

@guergana
@romicolman
I think it will require reworking components/Application/store.ts to support multiple active files (while not breaking the selected file logic). I've updated the Tech Effort to 3 but it might be even 5 as I see it now. Anyway, probably a good issue to get used to Zustand and TreeView

Yeah, I am not sure this is the best issue for me now since I am still more or less onboarding. I might need your help at some point @roll

@roll
Copy link
Collaborator

roll commented Apr 30, 2024

@guergana
Sure! Anyway it's in the backlog for now

@romicolman
Copy link
Collaborator Author

@roll / @guergana: I'm moving this issue to Sprint 3, since it requires more in-depth conversations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality Stable release This needs to be done for the launch stable version
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants