Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Rosie with year filter #562

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve Rosie with year filter #562

wants to merge 1 commit into from
+50 −30

Conversation

andreformento
Copy link

What is the purpose of this Pull Request?

  • Fix Rosie local build. Because for me it is not working 😢
  • Add a year filter to run local because these process use a lot of resources (like memory)

What was done to achieve this purpose?

  • Change base image of Dockerfile because current image doesn't work (for me, or I don't know how to run local)
  • Add a year parameter to run application and do a filter

How to test if it really works?

  • I changed readme and you should be able to understand using it

Who can help reviewing it?
@giuliocc and me

@andreformento
WIP: fix rosie process
c0cce5c 
fix start year

running with year filter

remove logs

logging

update readme

last years

fix years value

remove starting_year

fix federal

optimize filter
@andreformento andreformento mentioned this pull request Aug 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@andreformento