Uses Django Public Admin package #524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cuducos
force-pushed
the
cuducos-use-public-admin-pkg
branch
4 times, most recently
from
c1045e6
to
d6f6490
Compare
cuducos
force-pushed
the
cuducos-use-public-admin-pkg
branch
from
d6f6490
to
fa0ee1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this Pull Request?
I extract
jarbas.public_adminas a pip installable so we can use it in other civic tech projects (e.g., DadosAbertosDeFeira/maria-quiteria#65), this this code can be maintained outside Serenata if needed.What was done to achieve this purpose?
I replaced the
jarbas.public_adminby the external package.How to test if it really works?
Basically nothing i supopsed to change, the dashboard should still be read-only and public accessible.
TODO
I'm still refining the external package, but I tested locally with Jarbas and it worked, so I'm sharing the code, but we can only merge this once I publish the package to PyPI (that's why it's still a draft PR).Done.