Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Criado Spider para MG Piumhi #1044

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Criado Spider para MG Piumhi #1044

wants to merge 8 commits into from

Conversation

vinibispo
Copy link

@vinibispo vinibispo commented Nov 24, 2023 •
edited

Checklist - Novo spider

  • Você executou uma extração completa do spider localmente e os dados retornados estavam corretos.
  • Você executou uma extração por período (start_date e end_date definidos) ao menos uma vez e os dados retornados estavam corretos.
  • Você verificou que não existe nenhum erro nos logs (log_count/ERROR igual a zero).
  • Você definiu o atributo de classe start_date no seu spider com a data do Diário Oficial mais antigo disponível na página da cidade.
  • Você garantiu que todos os campos que poderiam ser extraídos foram extraídos de acordo com a documentação.

Descrição

#1009

rennerocha
rennerocha requested changes Dec 16, 2023
View reviewed changes
Copy link
Member

@rennerocha rennerocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obrigado pelo PR. Adicionei algumas sugestões de melhorias.

data_collection/gazette/spiders/mg/mg_piumhi.py Outdated Show resolved Hide resolved
data_collection/gazette/spiders/mg/mg_piumhi.py Outdated Show resolved Hide resolved
data_collection/gazette/spiders/mg/mg_piumhi.py Outdated Show resolved Hide resolved
data_collection/gazette/spiders/mg/mg_piumhi.py Outdated Show resolved Hide resolved
vinibispo and others added 6 commits December 18, 2023 06:39
@vinibispo @rennerocha
Update data_collection/gazette/spiders/mg/mg_piumhi.py
c8caf4b 
Co-authored-by: Renne Rocha <renne@rocha.dev.br>
Signed-off-by: Vinícius Bispo <vini.bispo015@gmail.com>
@vinibispo @rennerocha
Update data_collection/gazette/spiders/mg/mg_piumhi.py
5e03b47 
Co-authored-by: Renne Rocha <renne@rocha.dev.br>
Signed-off-by: Vinícius Bispo <vini.bispo015@gmail.com>
@vinibispo @rennerocha
Update data_collection/gazette/spiders/mg/mg_piumhi.py
966a264 
Co-authored-by: Renne Rocha <renne@rocha.dev.br>
Signed-off-by: Vinícius Bispo <vini.bispo015@gmail.com>
@vinibispo
Update mg_piumhi.py
0a67b17 
Signed-off-by: Vinícius Bispo <vini.bispo015@gmail.com>
@vinibispo
Update data_collection/gazette/spiders/mg/mg_piumhi.py
57c1d9d
@vinibispo
Merge branch 'okfn-brasil:main' into feature/mg_piumhi
dda6322
@trevineju trevineju linked an issue Jan 29, 2024 that may be closed by this pull request
[Novo spider]: Piumhi-MG #1009
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rennerocha rennerocha rennerocha requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Novo spider]: Piumhi-MG
2 participants
@vinibispo @rennerocha