Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependencies): improve and enable cron-based checks #12408

Merged
merged 6 commits into from May 12, 2024

Conversation

carlosala
Copy link
Member

@carlosala carlosala commented May 9, 2024

Standards checklist:

  • The PR title is descriptive.
  • The PR doesn't replicate another PR which is already open.
  • I have read the contribution guide and followed all the instructions.
  • The code follows the code style guide detailed in the wiki.
  • The code is mine or it's from somewhere with an MIT-compatible license.
  • The code is efficient, to the best of my ability, and does not waste computer resources.
  • The code is stable and I have tested it myself, to the best of my abilities.
  • If the code introduces new aliases, I provide a valid use case for all plugin users down below.

Closes #12178

Changes:

  • Use semver-based tag verification
  • Enable cron-based action run

Fixes:

  • Avoid creating PR if it was created previously.

Other stuff:

  • Update requirements
  • Use actions/setup-python to ensure Python version consistency
  • Run ruff formatter

Copy link
Member

@mcornella mcornella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice! Only some missing edge case, but the PR is almost ready to go! :shipit:

.github/workflows/dependencies/updater.py Outdated Show resolved Hide resolved
.github/workflows/dependencies/updater.py Show resolved Hide resolved
.github/workflows/dependencies/updater.py Outdated Show resolved Hide resolved
@carlosala carlosala requested a review from mcornella May 12, 2024 09:51
Copy link
Member

@mcornella mcornella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some more thingies

.github/workflows/dependencies/updater.py Outdated Show resolved Hide resolved
.github/workflows/dependencies/updater.py Show resolved Hide resolved
Copy link
Member

@mcornella mcornella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlosala carlosala merged commit eff648a into ohmyzsh:master May 12, 2024
2 checks passed
@carlosala carlosala deleted the cs-dependencies branch May 12, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Improve and smarten dependency updater
2 participants