Merge pull request #6 from ohdsi-studies/develop

fixing cohortId bug
ohdsi-studies · Nov 14, 2023 · c2107dd · c2107dd
2 parents 9ec4e1e + cde9e19
commit c2107dd
Show file tree

Hide file tree

Showing 6 changed files with 582 additions and 62 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,5 +1,5 @@
 Package: EhdenAlopecia 
-Version: 1.1.0
+Version: 1.1.1
 Authors@R: person("Ross", "Williams", , "r.williams@derasmusmc.nl", role = c("aut", "cre"))
 Description: This package creates the cohorts for this EHDEN Alopecia study study. Based on this cohort diagnostics, incidence and prevalence rates and treatment patterns are analysis are performed.
 License: Apache License (>= 2)

diff --git a/R/createCohorts.R b/R/createCohorts.R
@@ -28,7 +28,7 @@ createCohorts <- function(connectionDetails,
   cohortJson <- readChar(cohortJsonFileName, file.info(cohortJsonFileName)$size)
   cohortExpression <- CirceR::cohortExpressionFromJson(cohortJson)
   cohortSql <- CirceR::buildCohortQuery(cohortExpression, options = CirceR::createGenerateOptions(generateStats = FALSE))
-  cohortsToCreate <- rbind(cohortsToCreate, data.frame(cohortId = 91+i,
+  cohortsToCreate <- rbind(cohortsToCreate, data.frame(cohortId = as.numeric(cohortName),
                                                        cohortName = cohortName, 
                                                        sql = cohortSql,
                                                        stringsAsFactors = FALSE))