doctor: check if Git remotes match db URLs #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scorphus
commented
Jul 31, 2021
Comment on lines
+4
to
+5
| and test "$git_dir" = "$repo_dir" | ||
| or return 1 |
There was a problem hiding this comment.
@oranja, these are the only two of lines I've got a comment for. I tested this change in many different ways, one of them using a soft link to a plugin. In this case, nothing is returned and I end up with something like:
Warning: The remote URI for apt doesn't match the URI in OMF's database.
Remote URI:
Index URI: https://github.com/oh-my-fish/plugin-apt
A missing remote URI, even though the plugin works fine.
Perhaps there could be a previous check for such cases with an appropriate warning.
What do you think?
scorphus
force-pushed
the
doctor-db
branch
4 times, most recently
from
e33beaa
to
9d58ad9
Compare
Co-authored-by: Pablo Santiago Blum de Aguiar <scorphus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing @oranja's work.