appveyor.yml unnecessarily complicated #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the appveyor.yml most string scalars (but not all) were double quoted scalars. YAML allows any string through backslashes within double quotes, but also requires backslashes and double quotes to be escaped. The example can be made much more readable by using non-quoted scalar strings, or single quoted ones (in case the scalar starts with a `%` or can be interpreted as an integer. This was originally proposed as change for the user guide (pypa/packaging.python.org#221 (comment)) (Depending on how the program that loads the file handles the value for `PYTHON_ARCH`, the quotes around those values could be removed as well, assuming the program transparently converts from integer to string internally if necessary. )
|
Unfortunately this wasnt merged at the time, and now needs a rebase. Also can you test if it works without quotes around python-appveyor-demo/appveyor/install.ps1 Line 225 in f54ec35 |
|
I am not sure how I can test the PYTHON_ARCH, I have not seen the code that actually reads the YAML and sets the environment variables before invoking |
cclauss
added a commit
to cclauss/python-appveyor-demo
that referenced
this pull request
Jan 26, 2019
Drop Python 2.6 which reached its end of life more than five years ago and 3.4 which will reach its end of life in less than 50 days. https://devguide.python.org/#status-of-python-branches Also implements some of the good ideas from ogrisel#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most string scalars (but not all) are double quoted scalars, making the file less readable.
YAML allows any string through backslashes within double quotes, but also requires backslashes and double quotes to be escaped. The example can be made much more readable
by using non-quoted scalar strings, or single quoted ones (in case the scalar starts with a
%or can be interpreted as an integer.This was originally proposed as change for the user guide (pypa/packaging.python.org#221 (comment))
(Depending on how the program that loads the file handles the value for
PYTHON_ARCH, the quotes around those values could be removed as well, assuming the program transparently converts from integer to string internally if necessary. )